[pull] master from ruby:master #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #15212 these are proper syntax errors, so no need to handle this explicitly anymore. Also updated the example in the docs for this
When term len != 1 (for example: Encoding::UTF32BE), term fill is wrong size.
While parsing ISO 8601 timestamps like `2025-11-13T19:34:23.681726000Z` I noticed that a lot of time was spent to compute a default `year` argument to `zone_offset`. For ISO 8601, that year is never used, as all valid time zone designators match one of the earlier cases. This commit moves the computation of the default `year` value to just before it is used. This results in a 15% speedup parsing ISO 8601 timestamps on Mac OS X. ruby/time@4a0bcbe575
I noticed some of the keys have been gone or renamed for a while.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )