Draft
Conversation
Taken from tstack#410 (comment) Co-Authored-By: Adam Spiers <adam@spiers.net> Co-Authored-By: Nicolas Bock <nicolasbock@gmail.com> Signed-off-by: Nicolas Bock <nicolasbock@gmail.com>
Owner
|
This is marked as a Draft, is there anything else you want to do? |
Contributor
Author
|
It's working but I wanted to give myself a bit more time with it to see if everything is in there. Unfortunately the performance is not great. Loading a 4GiB log file takes upwards of 10 minutes. Fortunately I will test it out today a bit more and then give it 👍 or 👎 😄 |
aspiers
reviewed
Jul 31, 2021
| "rabbitmq_log": { | ||
| "regex": { | ||
| "connection": { | ||
| "pattern" : "^=(?<level>[A-Z]+) REPORT==== (?<timestamp>\\d\\d?-\\w{3}-\\d{4}::\\d{2}:\\d{2}:\\d{2}) ===(\\n(?<body>(closing AMQP connection <(?<stuff>.+)> \\((?<sourceIP>\\d[\\d.]+\\d?):(?<sourcePort>\\d+) -> (?<destIP>\\d[\\d.]+\\d?):(?<destPort>\\d+)\\))?(.*\\n)*))?$" |
Contributor
There was a problem hiding this comment.
I wonder if the performance issue could be mitigated by tweaking this a bit. For example changing the .+ inside <(?<stuff>.+)> to [^>]+ so that the regexp matching engine doesn't have to do any backtracking. Just a guess, not sure if it will help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from #410 (comment)
Co-Authored-By: Adam Spiers adam@spiers.net
Co-Authored-By: Nicolas Bock nicolasbock@gmail.com
Signed-off-by: Nicolas Bock nicolasbock@gmail.com