Open
Conversation
From `man 3 fread`: > The function **fread()** does not distinguish between end-of-file and > error; callers must use `feof(3)` and `ferror(3)` to determine which > occurred. > The function **fwrite()** returns a value less than _nitems_ only if a > write error has occurred. So we don't need to loop and check for `fwrite`, since it only returns anything smaller than `size` if it failed. It also doesn't set `ferror` so that's the wrong way to test for an error. Also, while `man` says nothing about `errno`, the UNIX spec for `fread` and `fwrite` says: > Otherwise, if a read error occurs, the error indicator for the stream > is set and _errno_ is set to indicate the error. (See [here](https://pubs.opengroup.org/onlinepubs/7908799/xsh/fread.html)) So I removed the TODO comment about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From
man 3 fread:So we don't need to loop and check for
fwrite, since it only returns anything smaller thansizeif it failed. It also doesn't setferrorso that's the wrong way to test for an error.Also, while
mansays nothing abouterrno, the UNIX spec forfreadandfwritesays:(See here)
So I removed the TODO comment about it.