nob_cmd_render and nob__cmd_start_process#126
Open
fbucafusco wants to merge 3 commits intotsoding:mainfrom
Open
nob_cmd_render and nob__cmd_start_process#126fbucafusco wants to merge 3 commits intotsoding:mainfrom
fbucafusco wants to merge 3 commits intotsoding:mainfrom
Conversation
accepts arguments with empty strings
JayLCypher
reviewed
Sep 7, 2025
| for (size_t i = 0; i < cmd.count; ++i) { | ||
| const char *arg = cmd.items[i]; | ||
| if (arg == NULL) break; | ||
| if( arg[0] == '\0' ) continue; |
There was a problem hiding this comment.
It would be a good idea to conform the style to what is around. The spaces after ( and before ).
Less work for Zozin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes nob for when you have this pattern:
#ifdef OPTIM#define CFLAGS "-O2"#else#define CFLAGS ""#endif....
cmd_append(&cmd, COMPILER_C, "-c" , "file.c" , CFLAGS , INCLUDES , "-o", "myexec");When
OPTIMis not defined, thenCFLAGSis "" andexecvpfails.also works with
#define CFLAGS NULLAlso fixes
nob_cmd_render.