-
Notifications
You must be signed in to change notification settings - Fork 7
Add support for zarr v3 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
462c71d to
93cabed
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 97.32% 96.76% -0.57%
==========================================
Files 6 7 +1
Lines 337 371 +34
Branches 56 60 +4
==========================================
+ Hits 328 359 +31
- Misses 7 8 +1
- Partials 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks pretty unobtrusive
tszip/compat.py
Outdated
| @@ -0,0 +1,51 @@ | |||
| # MIT License | |||
| # | |||
| # Copyright (c) 2019 Tskit Developers | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
year is wrong
5737b01 to
9fea23c
Compare
I missed a few things - it's a little more intrusive now, but still pretty good. |
c510ec4 to
7d641fe
Compare
Closes #97
Add support for zarr v3, tests for reading from either v2 or v3 from a file written by v2 or v3.