Skip to content

Conversation

@szabgab
Copy link

@szabgab szabgab commented Oct 24, 2025

Introduce running mypy in the pre-commit hook and in the CI (GitHub Actions).
This will ensure no new types of type-annotation issue enters the code-base and it is the first step to enhance the type safety of the Python code.

Starts the work on #3304

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

* Add mypy configuration file excluding errors to make mypy pass.
* Add CI to run mypy
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (52a1bcc) to head (64483b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3305   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files          29       29           
  Lines       31026    31026           
  Branches     5679     5679           
=======================================
  Hits        27863    27863           
  Misses       1777     1777           
  Partials     1386     1386           
Flag Coverage Δ
c-tests 86.85% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 87.05% <ø> (ø)
python-tests 98.84% <ø> (ø)
python-tests-no-jit 33.60% <ø> (ø)
python-tests-numpy1 50.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjeffery
Copy link
Member

Not planned as discussed in #3304

@benjeffery benjeffery closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants