Skip to content

Separate files and type hinting improvements#94

Merged
bmos merged 11 commits intomasterfrom
separate_files
Apr 20, 2025
Merged

Separate files and type hinting improvements#94
bmos merged 11 commits intomasterfrom
separate_files

Conversation

@bmos
Copy link
Contributor

@bmos bmos commented Apr 14, 2025

  • Use selenium.webdriver.Chrome() and selenium.webdriver.Firefox() instead of selenium.webdriver.chrome.webdriver.WebDriver() and selenium.webdriver.firefox.webdriver.WebDriver()
  • Break requestium file into requestium_session, requestium_mixin, and requestium_response
  • Add type hints to all functions and classes
  • Move session creating to fixture with per-execution initialization (no global webdriver anymore, yay)
    • Needed to remove chrome_webdriver_path from tests for now

@github-actions
Copy link

github-actions bot commented Apr 14, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  requestium
  requestium.py
  requestium_mixin.py 28-31, 59, 64-65, 80, 97, 100, 103, 106, 109, 112, 115, 118, 163, 165, 168-172, 187, 190, 193, 196, 199, 221-237
  requestium_response.py 21, 24, 27, 30, 33
  requestium_session.py 62, 72, 75, 79-80, 85-87, 90-91, 95-96, 128-132, 140-142, 145-147
Project Total  

This report was generated by python-coverage-comment-action

@bmos bmos force-pushed the separate_files branch 3 times, most recently from c8efd4e to 8c3b7b3 Compare April 16, 2025 21:51
@bmos bmos marked this pull request as ready for review April 20, 2025 00:58
@bmos bmos merged commit 74a2d8b into master Apr 20, 2025
25 checks passed
@bmos bmos deleted the separate_files branch April 20, 2025 12:26
@bmos bmos mentioned this pull request Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant