fix(vm): harden async-generator/eval paths (#706, #707, #708, #709)#950
Open
replygirl wants to merge 1 commit intotrynova:mainfrom
Open
fix(vm): harden async-generator/eval paths (#706, #707, #708, #709)#950replygirl wants to merge 1 commit intotrynova:mainfrom
replygirl wants to merge 1 commit intotrynova:mainfrom
Conversation
…rynova#708, trynova#709) Harden async generator state transitions and queue-drain handling to avoid unreachable/panic paths, and convert invalid eval VM await/yield completions into SyntaxError instead of crashes. Also updates Test262 expectations for the now-passing async generator and SM async crash tests. Fixes trynova#706 Fixes trynova#707 Fixes trynova#708 Fixes trynova#709
Author
|
i am out of my depth here but the tests pass 🤷♀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden async generator state transitions and queue-drain handling to avoid unreachable/panic paths, and convert invalid eval VM await/yield completions into SyntaxError instead of crashes.
Also updates Test262 expectations for the now-passing async generator and SM async crash tests.
Fixes #706
Fixes #707
Fixes #708
Fixes #709