refactor(cli): Refactor execution & microtasks into CliRunner struct#344
Open
andreubotella wants to merge 1 commit intotrynova:mainfrom
Open
refactor(cli): Refactor execution & microtasks into CliRunner struct#344andreubotella wants to merge 1 commit intotrynova:mainfrom
CliRunner struct#344andreubotella wants to merge 1 commit intotrynova:mainfrom
Conversation
In order to add a repl to the cli, trynova#323 moved the `initialize_global_object` and `exit_with_parse_errors` functions into a new `helper` module. However, this still left duplicate code between the `eval` and `repl` commands. This patch moves the isolate and realm initialization, as well as the script execution and microtask checkpoint, to a new `CliRunner` struct that lives in the `helper` module. Aside from just refactoring, this patch makes two visible changes related to promise jobs: - When passing multiple files to `eval`, now promise jobs run after each script execution, rather than at the end. - In `repl` mode it used to be that promise jobs were never run. Now, all promise jobs enqueued when running a line of JS are run before the result is printed.
Member
|
I'd kind of want to land #268 before this. Making GC work would be kind of nice, even if the API is pretty ugly. |
aapoalas
approved these changes
Mar 2, 2025
Member
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
LGTM: We could merge this if you have the time to solve the merge conflicts?
Collaborator
Author
Can't right now, but maybe in a couple hours. |
Member
Absolutely no rush <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to add a repl to the cli, #323 moved the
initialize_global_objectandexit_with_parse_errorsfunctions into a newhelpermodule. However, this still left duplicate code between theevalandreplcommands.This patch moves the isolate and realm initialization, as well as the script execution and microtask checkpoint, to a new
CliRunnerstruct that lives in thehelpermodule.Aside from just refactoring, this patch makes two visible changes related to promise jobs:
eval, now promise jobs run after each script execution, rather than at the end.replmode it used to be that promise jobs were never run. Now, all promise jobs enqueued when running a line of JS are run before the result is printed.