Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

The function is_plan_upgrade checked if a user's plan tier is strictly higher than required, but the name implied upgrade detection. Renamed to is_plan_higher_tier for clarity.

Changes:

  • Renamed is_plan_upgradeis_plan_higher_tier in utils.rs, client.rs, tests.rs
  • Updated test function name and comment to use consistent "higher tier" terminology

Context:

// Function checks: enterprise > professional > basic
pub(crate) fn is_plan_higher_tier(user_plan: &str, required_plan: &str) -> bool {
    // Returns true only when user_level > required_level (strictly greater)
    user_level > required_level
}

// Usage in access control
user_plan == required_plan_name || is_plan_higher_tier(&user_plan, required_plan_name)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 4, 2026 09:33
Co-authored-by: vsilent <42473+vsilent@users.noreply.github.com>
Co-authored-by: vsilent <42473+vsilent@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 4, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • stackerdb
    • Triggering command: /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc --crate-name stacker --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --diagnostic-width=120 --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --test --cfg feature=&#34;default&#34; --cfg feature=&#34;indexmap&#34; --check-cfg cfg(docsrs,test) (dns block)
    • Triggering command: /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc --crate-name stacker --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --emit=dep-info,link -C embed-bitcode=no -C debuginfo=2 --test --cfg feature=&#34;default&#34; --cfg feature=&#34;indexmap&#34; --check-cfg cfg(docsrs,test) --check-cfg (dns block)
    • Triggering command: /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc /home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/bin/rustc --crate-name stacker --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 --cfg feature=&#34;default&#34; --cfg feature=&#34;indexmap&#34; --check-cfg cfg(docsrs,test) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP Address feedback on user service refactoring PR Rename is_plan_upgrade to is_plan_higher_tier Feb 4, 2026
Copilot AI requested a review from vsilent February 4, 2026 09:38
@vsilent vsilent marked this pull request as ready for review February 4, 2026 13:15
@vsilent vsilent merged commit 5e2aef6 into feature-user-service-refactoring Feb 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants