Skip to content

fix(integrations): honor google sync exclusions for members#2909

Merged
tofikwest merged 1 commit into
mainfrom
tofik/fix-google-ignore-list
May 22, 2026
Merged

fix(integrations): honor google sync exclusions for members#2909
tofikwest merged 1 commit into
mainfrom
tofik/fix-google-ignore-list

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

@tofikwest tofikwest commented May 22, 2026

Summary

  • deactivate existing non-privileged Google Workspace members when their email matches the sync exclude list
  • use the unfiltered Google Workspace domain set during deactivation so excluded users in the managed domain are still considered
  • update the Google Workspace sync spec and fix its missing controller dependency mocks

Customer impact

Accounts such as shared inboxes or service accounts added to Google Workspace's "Exclude from Sync & Checks" list will disappear from the Active people list after the next sync, instead of remaining active forever if they were previously imported.

Verification

  • bunx jest src/integration-platform/controllers/sync-gws.controller.spec.ts --passWithNoTests
  • bunx prettier --check apps/api/src/integration-platform/controllers/sync-gws.controller.spec.ts
  • git diff --check

Notes: full-file eslint/prettier on sync.controller.ts still reports existing baseline issues in that large controller unrelated to this patch.


Summary by cubic

Honor Google Workspace sync exclusions by deactivating previously imported, non‑privileged members that match the exclude list. This removes excluded service accounts and shared inboxes from the Active people list on the next sync.

  • Bug Fixes
    • Deactivate excluded members in exclude mode and record a clear reason.
    • Use the unfiltered Google Workspace domain set during deactivation so excluded users in managed domains are handled.
    • Add missing controller dependency mocks and update the spec to reflect the new deactivation behavior.

Written for commit feb92ed. Summary will update on new commits. Review in cubic

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comp-framework-editor Ready Ready Preview, Comment May 22, 2026 2:25am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
app Skipped Skipped May 22, 2026 2:25am
portal Skipped Skipped May 22, 2026 2:25am

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@tofikwest tofikwest merged commit df225ad into main May 22, 2026
11 checks passed
@tofikwest tofikwest deleted the tofik/fix-google-ignore-list branch May 22, 2026 02:41
@claudfuen
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.62.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants