fix(integrations): honor google sync exclusions for members#2909
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 3.62.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Customer impact
Accounts such as shared inboxes or service accounts added to Google Workspace's "Exclude from Sync & Checks" list will disappear from the Active people list after the next sync, instead of remaining active forever if they were previously imported.
Verification
Notes: full-file eslint/prettier on sync.controller.ts still reports existing baseline issues in that large controller unrelated to this patch.
Summary by cubic
Honor Google Workspace sync exclusions by deactivating previously imported, non‑privileged members that match the exclude list. This removes excluded service accounts and shared inboxes from the Active people list on the next sync.
Written for commit feb92ed. Summary will update on new commits. Review in cubic