fix(people): address third round of cubic review findings#2891
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
- fix test mock: findUnique → findFirst for undoVendorRevocation - guard uploadEmploymentEvidence against missing userId in API key auth - change User onDelete to SetNull on completions/revocations (preserve audit) - add requireUserId helper to offboarding controller for all mutations - validate member belongs to org before revocation operations - validate provider date strings before converting to Date in sync - reject partial evidence payloads in revokeVendorAccess - add noopener,noreferrer to all window.open calls - disable attach evidence button while processing - handle error state explicitly in OffboardingBanner Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Marfuen
force-pushed
the
mariano/cs-312-cubic-review-fixes-3
branch
from
c1f7def to
1eff642
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
5 tasks
claudfuen
pushed a commit
that referenced
this pull request
May 21, 2026
# [3.60.0](v3.59.2...v3.60.0) (2026-05-21) ### Bug Fixes * **cloud-tests:** show meaningful Auto-Remediate diff for configure-only plans ([90c95f6](90c95f6)) * **evidence-export:** load automations one at a time to prevent OOM ([07f02e4](07f02e4)) * **people:** address cubic review findings for offboarding feature ([#2884](#2884)) ([9d43a6b](9d43a6b)) * **people:** address fifth round of cubic review findings ([#2893](#2893)) ([dbc364c](dbc364c)) * **people:** address fourth round of cubic review findings ([#2892](#2892)) ([ca9d9a5](ca9d9a5)) * **people:** address remaining cubic review findings for offboarding ([#2890](#2890)) ([8026352](8026352)) * **people:** address third round of cubic review findings ([#2891](#2891)) ([8ec5214](8ec5214)) * **people:** ds component compatibility fixes for offboarding UI ([200b112](200b112)) * **ui:** close MultipleSelector dropdown on blur so it stops blocking sibling form controls ([b9d08c8](b9d08c8)) ### Features * **api:** unblock cloud-tests mutations for API key + service token callers ([26e53da](26e53da)) * **cloud-tests:** add deterministic AWS plan normalizer for SLR params ([e0ec0f7](e0ec0f7)) * **cloud-tests:** fail fast on missing required AWS command params ([5f2d342](5f2d342)) * **cloud-tests:** universal AI step-repair on AWS validation errors ([8adf505](8adf505)) * **frameworks:** show controls as default tab with requirement column ([e41365d](e41365d)) * **people:** add employment events tracking and offboarding checklist ([5e15a73](5e15a73))
Contributor
|
🎉 This PR is included in version 3.60.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all remaining Cubic findings from #2878 (third review pass), focusing on security hardening and edge cases:
Security (P1):
userId(API key/service token auth)memberIdbelongs toorganizationIdbefore revocation operations (cross-tenant prevention)UseronDeletefromCascadetoSetNullon completions/revocations (preserve audit trail)uploadEmploymentEvidenceagainst missing user contextBug fixes (P2):
findUnique→findFirstforundoVendorRevocationDateconversion in sync controllernoopener,noreferrerto allwindow.open('_blank')callsTest plan
🤖 Generated with Claude Code
Summary by cubic
Hardens offboarding and people flows to close the third round of Cubic review findings. Supports CS-312 by safely importing onboard dates from integrations and making evidence uploads reliable.
memberIdbelongs toorganizationIdbefore any vendor revocation; return 404 on cross-tenant attempts.UserFKs on completions/revocations to SetNull instead of Cascade.revokeVendorAccess;fileName,fileType, andfileDatamust be provided together.onboardDatewhen provider date strings are valid in Google Workspace, Rippling, and JumpCloud imports.noopener,noreferrerto exports, and hide OffboardingBanner on API error.Written for commit 1eff642. Summary will update on new commits. Review in cubic