Conversation
…it-delete-finding-in-admin
…ow-comments-on-task-overview
…on-upload-issue
…voke The Mark-as-exception flow refreshed the active findings list but left the History tab's SWR cache stale, so a freshly-marked exception wouldn't appear in "Active exceptions" until the user reloaded. The mirror case applied to revoke — clearing an exception refreshed History but not the findings list, so the reopened finding stayed hidden from Scan Results. Both flows now invalidate the other cache using SWR's global mutate with a predicate. `useApiSWR` keys on `[endpoint, organizationId]`, so a string-prefix check on `key[0]` matches every cached variant regardless of which connection is currently in view. - CloudTestsSection: after `onMarked`, invalidate history caches - HistoryTab: after revoke, invalidate findings caches Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix(cloud-tests): sync findings + history caches on mark/revoke exception
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…d-comments-to-findings
fix: allow admin & owner to remove the device
…ating-finding CS-364 [BUG] remove "evidence submission" from add finding box
CS-367 [Feature] Ability to add comments directly to findings
Two parallel branches independently added 'finding' to the CommentEntityType enum: - 20260513220233_comment_entity_type_finding (from feat(cloud-tests): auditor visibility improvements, merged May 13) - 20260512120000_add_finding_to_comment_entity_type (from feat: add comments to findings, merged May 19 in PR #2827) The May 13 migration was deployed to staging first and recorded the enum label. When the main->release deploy ran prisma migrate deploy on staging, it tried to apply the earlier-timestamped May 12 migration and failed with P3018 / 42710 ("enum label \"finding\" already exists") because the value was already present. Both migrations did the same thing; keep the one that was actually deployed (May 13) and remove the duplicate. The schema is unchanged because the post-migration enum is identical. A one-time manual step is required on staging (and any environment where prisma migrate deploy has already recorded the failed migration) to clear the failed migration record: prisma migrate resolve --rolled-back \ 20260512120000_add_finding_to_comment_entity_type After that, prisma migrate deploy is a no-op for this change because the only remaining migration (May 13) is already applied. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
…num-migration fix(db): remove duplicate add-finding-to-CommentEntityType migration
Contributor
|
🎉 This PR is included in version 3.58.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.
Summary by cubic
Adds admin edit/delete for findings (DELETE endpoint + UI), adds comments on findings, syncs Cloud Tests + History via
swron mark/revoke, shows task comments, tightens file validation, lets admin/owner remove devices, removes "evidence submission" from Add Finding, and removes a duplicate migration for finding comments. Addresses CS-365, CS-367, CS-368, CS-400, CS-364.Written for commit 12c907b. Summary will update on new commits. Review in cubic