Conversation
[dev] [Marfuen] mariano/swap-onboarding-cloud-software-order
PR SummaryMedium Risk Overview Hardens trust-portal custom domain flows by URL-encoding domains in Vercel/networkcalc requests, preventing path injection, ensuring DNS checks only run for the organization’s configured domain, and syncing verification requirements/tokens from live Vercel status. Updates domain management to remove an old Vercel domain when switching, avoid deleting/re-adding domains already on the project (preserving verification tokens), and only mark Written by Cursor Bugbot for commit c21c656. This will update automatically on new commits. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
🎉 This PR is included in version 3.15.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| return { | ||
| success: true, | ||
| needsVerification: !domainVerified, | ||
| }; |
There was a problem hiding this comment.
Stale domainVerified preserved when Vercel status regresses
Medium Severity
In the alreadyOnProject branch, domainVerified is carried over from the DB (line 750–753) and stored in the upsert without considering the fresh Vercel state. If a previously verified domain now has statusData.verified === false (e.g., domain moved to another Vercel account), the DB ends up with domainVerified: true AND isVercelDomain: true simultaneously. The CORS query in auth.server.ts trusts domainVerified: true, so the domain stays in the allow-list even though Vercel can't serve it. The return value needsVerification: false also hides the verification UI from the user.


This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.