Skip to content

CS-219 Hide devices of platform admin users on People/Devices tab#2447

Merged
Marfuen merged 2 commits intomainfrom
chas/hide-platform-admin-devices
Apr 3, 2026
Merged

CS-219 Hide devices of platform admin users on People/Devices tab#2447
Marfuen merged 2 commits intomainfrom
chas/hide-platform-admin-devices

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 3, 2026

This is an automated pull request to merge chas/hide-platform-admin-devices into dev.
It was created by the [Auto Pull Request] action.

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 3, 2026

PR Summary

Low Risk
Low risk: only tightens query filters to exclude User.role='admin' records; main risk is unintentionally hiding devices if roles are misassigned.

Overview
Updates the People → Devices data loaders to exclude devices belonging to platform admin users.

Both the device-agent DB query (getEmployeeDevicesFromDB) and the Fleet legacy path (getFleetHosts member lookup) now apply a NOT user.role='admin' filter so platform-admin devices no longer appear in org device lists.

Written by Cursor Bugbot for commit 760fa00. This will update automatically on new commits. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Apr 3, 2026 1:40am
comp-framework-editor Ready Ready Preview, Comment Apr 3, 2026 1:40am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
portal Skipped Skipped Apr 3, 2026 1:40am

Request Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@chasprowebdev chasprowebdev changed the title [dev] [chasprowebdev] chas/hide-platform-admin-devices CS-219 Hide devices of platform admin users on People/Devices tab Apr 3, 2026
@linear
Copy link
Copy Markdown

linear bot commented Apr 3, 2026

@Marfuen Marfuen merged commit 13501bd into main Apr 3, 2026
11 checks passed
@Marfuen Marfuen deleted the chas/hide-platform-admin-devices branch April 3, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants