Conversation
[dev] [Marfuen] mariano/eng-198-error-trying-to-run-cloud-tests
Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
PR SummaryHigh Risk Overview Upgrades Prisma from Adds framework editor export/import endpoints ( Refactors API code/tests to import DB types via Written by Cursor Bugbot for commit cf9990b. This will update automatically on new commits. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
| 'The Security Command Center API is not enabled for this project. ' + | ||
| 'Enable it in the GCP console: APIs & Services > Enable APIs > Security Command Center API.', | ||
| ); | ||
| } |
There was a problem hiding this comment.
Specific GCP error checks unreachable due to ordering
Medium Severity
The new checks for Security Command Center Legacy and Security Command Center API has not been used are placed after the existing PERMISSION_DENIED/403 check. GCP API error responses typically embed the HTTP status code and gRPC status in the response body JSON, so these errors will almost always contain "403" or "PERMISSION_DENIED", causing the generic handler to match first. The more specific and helpful error messages will never be shown to users. The companion file packages/integrations/src/gcp/src/index.ts doesn't have this issue because it has no 403 catch-all.
Additional Locations (1)
The `next` package was listed as a dependency in `packages/email` but was never imported or used anywhere in the package. It is not a peer dependency of any of the package's actual dependencies (react-email, resend, etc.). Removing it to avoid unnecessary dependency maintenance. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Bumps the npm_and_yarn group with 1 update in the /packages/device-agent directory: [electron](https://github.com/electron/electron). Updates `electron` from 33.4.0 to 35.7.5 - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v33.4.0...v35.7.5) --- updated-dependencies: - dependency-name: electron dependency-version: 35.7.5 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
…2404) * fix(app): pass isPlatformAdmin value to FindingItem to make 'Ready for Review' enabled by client * fix(app): remove isAuditor and add canSetReadyForReview param to FindingItem * fix(app): remove isPlatformAdmin prop from FindingItem --------- Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
Ramp integration is no longer needed. This removes all Ramp-related code across the stack: manifest, API services/controllers, sync endpoints, frontend components (role mapping UI, sync provider), and scheduled sync. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Auto-clear employeeSyncProvider if the manifest no longer exists (covers orgs that had Ramp configured before removal) - Guard Image component against empty src when provider logo is missing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Generic manifest check would break dynamic providers during transient registry gaps. Scope to explicit 'ramp' check instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove Ramp integration
…able in Docker build context) (#2426)
… resolution in Docker) (#2427)
…chemas * refactor: simplify prisma schema sharing using native v7 multi-file schemas Replace combine-schemas.js-based pipeline with Prisma v7's native directory support. Each app now has its own prisma/schema/ dir with a local schema.prisma (committed) and copies model files from packages/db/prisma/schema/ at generate time (gitignored). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor: simplify prisma schema sharing and fix Docker build - Use native Prisma v7 multi-file schema (--schema=prisma/schema directory) - Each app has its own prisma/schema/schema.prisma with correct generator - generate-prisma-client-js.js creates temp dir with model files instead of combine-schemas - Remove PoolConfig import from pg (not a direct dependency) - Keep bun:1.2.8 for builder (compatible with workspace resolution), node:22 for production - Restore original COPY order in Dockerfile (no node_modules restore needed) --------- Co-authored-by: Mariano Fuentes <marfuen98@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…Url stripping (#2430) Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
…2434) Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>
…ssl option (#2435) PrismaPg receives both `sslmode=require` in the connection string and an explicit `ssl` option. This double-SSL configuration can cause intermittent connection failures on staging (ECS + RDS). Uses the URL API to safely remove the sslmode param instead of the old buggy regex approach. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: strip sslmode from DATABASE_URL to avoid conflict with explicit ssl option PrismaPg receives both `sslmode=require` in the connection string and an explicit `ssl` option. This double-SSL configuration can cause intermittent connection failures on staging (ECS + RDS). Uses the URL API to safely remove the sslmode param instead of the old buggy regex approach. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: exclude test files from tsc compilation in packages/db The bun:test import in strip-ssl-mode.test.ts breaks the Docker build which uses tsc (not bun) to compile packages/db. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Mariano Fuentes <marfuen98@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix: strip sslmode from DATABASE_URL to avoid conflict with explicit ssl option PrismaPg receives both `sslmode=require` in the connection string and an explicit `ssl` option. This double-SSL configuration can cause intermittent connection failures on staging (ECS + RDS). Uses the URL API to safely remove the sslmode param instead of the old buggy regex approach. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: exclude test files from tsc compilation in packages/db The bun:test import in strip-ssl-mode.test.ts breaks the Docker build which uses tsc (not bun) to compile packages/db. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove redundant prisma generate from Docker build The @prisma/client is already generated by packages/db build step (generate-prisma-client-js.js). The second prisma generate in the API build step was redundant and failing with an empty error in Docker. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: update Trigger.dev extensions to copy entire schema directory Both customPrismaExtension.ts files (api + app) now copy the full multi-file schema directory instead of a single file. This ensures prisma generate sees all model files, not just the generator/datasource. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Mariano Fuentes <marfuen98@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |


This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.