[dev] [carhartlewis] lewis/comp-device-agent-overhaul by github-actions[bot] · Pull Request #2115 · trycompai/comp

github-actions · 2026-02-08T17:48:05Z

This is an automated pull request to merge lewis/comp-device-agent-overhaul into dev.
It was created by the [Auto Pull Request] action.

…ases

vercel · 2026-02-08T17:48:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app	Ready	Preview, Comment	Feb 11, 2026 0:17am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
portal	Skipped		Feb 11, 2026 0:17am

cursor · 2026-02-08T17:48:11Z

PR Summary

Medium Risk
Touches CI release automation and production-facing People/Devices data paths by changing how device lists are sourced/merged and how device records are deleted on unlink; failures could affect release publishing or device visibility/compliance reporting, though Fleet fallback and error-to-empty handling reduce blast radius.

Overview
Adds a new GitHub Actions workflow to build, code-sign, version, tag, and publish packages/device-agent installers for macOS/Windows/Linux (production tags on release, staging prereleases on other branches), attaching artifacts to GitHub Releases.

Updates the API DevicesService to become a hybrid device source: fetches devices from both FleetDM and the new Device Agent DB models, deduplicates/merges via mergeDeviceLists, and annotates results with a source field; DeviceResponseDto is widened to allow string IDs and include source, and FleetDM integration is marked deprecated. Member device unlinking now also deletes device-agent Device records.

Revamps the app’s People area to surface device-agent data end-to-end: introduces DeviceWithChecks types, fetches latest-per-check results from DB, merges with Fleet devices, adds per-member tasks completion counts in the team table, and updates employee/device UI to new design-system components with richer device/check detail views and pagination/search. The portal’s employee task flow now checks device-agent compliance status (with Fleet fallback) and updates install instructions to point to GitHub releases, including Linux support.

^{Written by Cursor Bugbot for commit 493f881. This will update automatically on new commits. Configure here.}

apps/api/src/devices/devices.service.ts

apps/app/src/app/(app)/[orgId]/people/devices/components/EmployeeDevicesColumns.tsx

apps/app/src/app/(app)/[orgId]/people/devices/data/index.ts

apps/app/src/app/(app)/[orgId]/people/devices/components/EmployeeDevicesList.tsx

…hemas

apps/portal/src/app/(app)/(home)/[orgId]/components/EmployeeTasksList.tsx

apps/app/src/app/(app)/[orgId]/people/devices/data/index.ts

apps/app/src/app/(app)/[orgId]/people/dashboard/components/EmployeeCompletionChart.tsx

apps/app/src/app/(app)/[orgId]/people/devices/components/EmployeeDevicesList.tsx

…flow

apps/app/src/app/(app)/[orgId]/people/devices/data/index.ts

apps/app/src/app/(app)/[orgId]/people/dashboard/components/EmployeesOverview.tsx

apps/api/src/devices/devices.service.ts

….json

cursor · 2026-02-08T20:02:44Z

apps/api/src/devices/devices.service.ts

+    dto.hardware_model = device.hardwareModel ?? '';
+    dto.seen_time = device.lastCheckIn?.toISOString() ?? '';
+    dto.created_at = device.installedAt.toISOString();
+    dto.updated_at = device.installedAt.toISOString();


API returns incorrect updated_at timestamp for device-agent devices

Medium Severity

The mapAgentDeviceToDto function sets dto.updated_at to device.installedAt.toISOString(), which is the same value as created_at. This is incorrect since lastCheckIn is available (used on line 292 for seen_time) and would be the semantically correct value for updated_at. API consumers expecting updated_at to reflect when the device record was last updated will receive stale data that never changes after initial creation.

cursor

Cursor Bugbot has reviewed your changes and found 4 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-02-11T12:28:28Z

apps/app/src/app/(app)/[orgId]/people/devices/data/index.ts

+              details: { message: host.disk_encryption_enabled ? 'Enabled' : 'Not enabled' },
+              checkedAt: host.seen_time || new Date().toISOString(),
+            },
+          ],


Fleet device compliance only checks disk encryption

Medium Severity

In getFleetDevices, isCompliant for fleet devices is now determined solely by host.disk_encryption_enabled. Previously, compliance was based on all fleet policies passing (including MDM enrollment on macOS). This regression means fleet devices may show as "Compliant" in the compliance chart despite failing other policy checks, misleading users about their security posture.

cursor · 2026-02-11T12:28:28Z

apps/app/src/app/(app)/[orgId]/people/devices/components/DeviceDetails.tsx

+  macos: 'macOS',
+  windows: 'Windows',
+  linux: 'Linux',
+};


Duplicated CHECK_NAMES and PLATFORM_LABELS constants across files

Low Severity

The CHECK_NAMES and PLATFORM_LABELS constants are identically defined in DeviceDetails.tsx, EmployeeTasks.tsx, and EmployeeDevicesList.tsx. Adding a new check type or platform label requires updating all three files, and inconsistencies are likely (as already seen in the dead EmployeeDevicesColumns.tsx which is missing linux). These belong in a shared constants module.

Additional Locations (2)

apps/app/src/app/(app)/[orgId]/people/[employeeId]/components/EmployeeTasks.tsx#L29-L41

apps/app/src/app/(app)/[orgId]/people/devices/components/EmployeeDevicesList.tsx#L29-L41

cursor · 2026-02-11T12:28:28Z

apps/app/src/app/(app)/[orgId]/people/dashboard/components/EmployeeCompletionChart.tsx

-                ) : (
-                  <button
-                    onClick={loadMore}
-                    className="text-primary hover:text-primary/80 text-sm font-medium"


Refactored EmployeeCompletionChart is now unused dead code

Low Severity

EmployeeCompletionChart was substantially rewritten (269 lines) but its only consumer, EmployeesOverview, was deleted in this same PR. A codebase-wide search confirms no remaining imports of EmployeeCompletionChart. This leaves a large, newly refactored component as dead code.

cursor · 2026-02-11T12:28:28Z

apps/app/src/app/(app)/[orgId]/people/all/components/TeamMembers.tsx

+        completed: policiesCompleted + trainingsCompleted,
+        total: totalTasks,
+      };
+    }


Training completion count may exceed total for task badge

Low Severity

The trainingsCompleted count in TeamMembers.tsx counts all DB completion records with completedAt !== null, without filtering to only videos that still exist in trainingVideosData. Meanwhile totalTrainingVideos is derived from trainingVideosData.length. If a training video is retired from the static list but a completion record remains, completed can exceed total, producing a display like "6/5" in the TASKS badge.

feat(device-agent): new device agent package and CI workflow for rele…

6563a38

…ases

github-actions bot added the automated-pr label Feb 8, 2026

mintlify bot deployed to staging - packages/docs February 8, 2026 17:48 View deployment

vercel bot had a problem deploying to Preview – app February 8, 2026 17:49 Failure

vercel bot had a problem deploying to Preview – portal February 8, 2026 17:49 Failure

cursor bot reviewed Feb 8, 2026

View reviewed changes

feat(devices): add linux platform support to device interfaces and sc…

d684c9a

…hemas

vercel bot had a problem deploying to Preview – app February 8, 2026 18:01 Failure

vercel bot had a problem deploying to Preview – portal February 8, 2026 18:01 Failure

cursor bot reviewed Feb 8, 2026

View reviewed changes

apps/portal/src/app/(app)/(home)/[orgId]/components/EmployeeTasksList.tsx Outdated Show resolved Hide resolved

apps/app/src/app/(app)/[orgId]/people/devices/data/index.ts Show resolved Hide resolved

refactor(people): update Employee component to use button rendering

3511458

vercel bot deployed to Preview – app February 8, 2026 18:31 View deployment

vercel bot deployed to Preview – portal February 8, 2026 18:32 View deployment

refactor(devices): simplify device ID handling and update DTO definition

dc9954a

vercel bot deployed to Preview – app February 8, 2026 18:54 View deployment

vercel bot deployed to Preview – portal February 8, 2026 18:54 View deployment

cursor bot reviewed Feb 8, 2026

View reviewed changes

apps/app/src/app/(app)/[orgId]/people/dashboard/components/EmployeeCompletionChart.tsx Outdated Show resolved Hide resolved

apps/app/src/app/(app)/[orgId]/people/devices/components/EmployeeDevicesList.tsx Show resolved Hide resolved

feat(api): add organization membership verification for device check-in

5354445

vercel bot temporarily deployed to Preview – app February 8, 2026 18:57 Inactive

carhartlewis added 2 commits February 8, 2026 18:58

refactor(api): update device ID definition to support multiple types

18ecfd9

feat(devices): add linux support to platform labels in device components

d0992c4

vercel bot temporarily deployed to Preview – portal February 8, 2026 18:59 Inactive

mintlify bot deployed to staging - packages/docs February 8, 2026 19:00 View deployment

vercel bot deployed to Preview – app February 8, 2026 19:01 View deployment

refactor(people): update EmployeeCompletionChart to manage perPage state

96235a4

vercel bot temporarily deployed to Preview – portal February 8, 2026 19:04 Inactive

vercel bot deployed to Preview – app February 8, 2026 19:06 View deployment

feat(ci): enhance device agent release workflow with version detection

67c03b6

carhartlewis added 2 commits February 8, 2026 19:12

refactor(ci): update portal URL handling in device agent release work…

ef30c61

…flow

chore(device-agent): remove unused generate-icons script

d83f527

vercel bot temporarily deployed to Preview – app February 8, 2026 19:14 Inactive

vercel bot temporarily deployed to Preview – portal February 8, 2026 19:14 Inactive

cursor bot reviewed Feb 8, 2026

View reviewed changes

apps/app/src/app/(app)/[orgId]/people/devices/data/index.ts Outdated Show resolved Hide resolved

apps/app/src/app/(app)/[orgId]/people/dashboard/components/EmployeesOverview.tsx Show resolved Hide resolved

feat(devices): add mergeDeviceLists utility for device deduplication

b4571a9

vercel bot deployed to Preview – app February 8, 2026 19:42 View deployment

vercel bot deployed to Preview – portal February 8, 2026 19:42 View deployment

cursor bot reviewed Feb 8, 2026

View reviewed changes

apps/api/src/devices/devices.service.ts Show resolved Hide resolved

refactor(devices): update disk encryption check to use latest result

bfee4e3

vercel bot temporarily deployed to Preview – portal February 8, 2026 19:52 Inactive

vercel bot temporarily deployed to Preview – app February 8, 2026 19:52 Inactive

chore(device-agent): update version and author information in package…

32e56bc

….json

vercel bot temporarily deployed to Preview – portal February 8, 2026 19:53 Inactive

vercel bot temporarily deployed to Preview – app February 8, 2026 19:53 Inactive

cursor bot reviewed Feb 8, 2026

View reviewed changes

tofikwest self-requested a review February 9, 2026 15:02

Merge branch 'main' into lewis/comp-device-agent-overhaul

493f881

vercel bot temporarily deployed to Preview – portal February 11, 2026 12:15 Inactive

vercel bot deployed to Preview – app February 11, 2026 12:17 View deployment

cursor bot reviewed Feb 11, 2026

View reviewed changes

Conversation

github-actions bot commented Feb 8, 2026

Uh oh!

vercel bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot Feb 8, 2026

Choose a reason for hiding this comment

API returns incorrect updated_at timestamp for device-agent devices

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Feb 11, 2026

Choose a reason for hiding this comment

Fleet device compliance only checks disk encryption

Uh oh!

cursor bot Feb 11, 2026

Choose a reason for hiding this comment

Duplicated CHECK_NAMES and PLATFORM_LABELS constants across files

Uh oh!

cursor bot Feb 11, 2026

Choose a reason for hiding this comment

Refactored EmployeeCompletionChart is now unused dead code

Uh oh!

cursor bot Feb 11, 2026

Choose a reason for hiding this comment

Training completion count may exceed total for task badge

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel bot commented Feb 8, 2026 •

edited

Loading

cursor bot commented Feb 8, 2026 •

edited

Loading

Duplicated `CHECK_NAMES` and `PLATFORM_LABELS` constants across files

Refactored `EmployeeCompletionChart` is now unused dead code