ed25519 tests, perf test fix, dkim_free() memory leak, dkim_sig_keybits() #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts() Add 4 ed25519 directed tests and 2 ed25519 performance test scripts. In the Makefile t-cleanup is not part of $check_PROGRAMS anymore so that it can can be run after the $check_SCRIPTS tests instead of before them, allowing those tests to use the keyfile that t-cleanup deletes. Also fix 3 bugs found while doing the above. 1. The t-signperf and t-verifyperf performance tests were blindly looping on sign and verify operations without checking for correct results. They always reported "pass" even when the operation failed, for example when the key was not found. Now they assert the results and "fail" if something goes wrong. 2. In dkim_free() the ed25519 crypto structure wasn't getting freed. 3. In dkim_sig_keybits() the wrong size was being returned for ed25519. For now, always return 256 since ed25519 is always 256-bit. The underlying bug is in the calculation of 'keybits' in various other dkim functions and that will be fixed in a subesquent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 4 ed25519 directed tests and 2 ed25519 performance test scripts. In the Makefile t-cleanup is not part of $check_PROGRAMS anymore so that it can can be run after the $check_SCRIPTS tests instead of before them, allowing those tests to use the keyfile that t-cleanup deletes.
Also fix 3 bugs found while doing the above.
The t-signperf and t-verifyperf performance tests were blindly looping on sign and verify operations without checking for correct results. They always reported "pass" even when the operation failed, for example when the key was not found. Now they assert the results and "fail" if something goes wrong.
In dkim_free() the ed25519 crypto structure wasn't getting freed.
In dkim_sig_keybits() the wrong size was being returned for ed25519. For now, always return 256 since ed25519 is always 256-bit. The underlying bug is in the calculation of 'keybits' in various other dkim functions and that will be fixed in a subesquent PR.