feat(vm,consensus): harden resource calculations(TIP-833)#6721
Open
halibobo1205 wants to merge 4 commits intotronprotocol:developfrom
Open
feat(vm,consensus): harden resource calculations(TIP-833)#6721halibobo1205 wants to merge 4 commits intotronprotocol:developfrom
halibobo1205 wants to merge 4 commits intotronprotocol:developfrom
Conversation
github-actions
Bot
requested review from
CodeNinjaEvan,
lvs0075,
xxo1shine and
yanghang8612
halibobo1205
commented
May 6, 2026
| public long calculateGlobalEnergyLimit(AccountCapsule accountCapsule) { | ||
| long frozeBalance = accountCapsule.getAllFrozenBalanceForEnergy(); | ||
| if (frozeBalance < 1_000_000L) { | ||
| if (frozeBalance < precision) { |
halibobo1205
force-pushed
the
feature/tip-833-harden-resource-calculation
branch
from
2e97653 to
82d1639
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements TIP-833 to harden resource calculations across native and VM paths:
ResourceProcessor(increase/increaseV2/unDelegateIncreaseV2/getNewWindowSize/getUsage) andRepositoryImpl(increase/getUsage);longValueExact()performs an explicit range check before writing back to long, replacing silent overflow wrap with a deterministicArithmeticExceptionthat reverts the transaction.calculateGlobalEnergyLimit{,V2}andcalculateGlobalNetLimit{,V2}(and the VM-sidecalculateGlobalEnergyLimit) drop(long)((double) weight * limit / totalWeight)for two BigInteger helpers —calculateGlobalLimitV1(preserves "floorfrozeBalance/TRX_PRECISIONfirst") andcalculateGlobalLimitV2(single integer truncation, fractional weight preserved sofrozeBalance < TRX_PRECISIONstill yields a proportional non-zero result).EnergyProcessor.updateAdaptiveTotalEnergyLimitandRepositoryImpl.usageToBalance(the(long)((double) usage * weight/limit * TRX_PRECISION)reverse-calculation) move to BigInteger under the same gate.ALLOW_HARDEN_RESOURCE_CALCULATION(code 97), requires forkVERSION_4_8_2, one-time activation; behaviour pre-activation is byte-identical to current mainnet.Reference
TIP-833: Harden ResourceProcessor Resource Window Calculations