Skip to content

test for function with typeof not instanceof #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RamIdeas wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test for function with typeof not instanceof #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c46de29
test for function with `typeof` not `instanceof`
RamIdeas Nov 6, 2020
71dc258
check for RegExp duck-type
RamIdeas Nov 13, 2020
c5f4e6d
differentiate regex using `typeof string`
RamIdeas Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Path.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ export class Path<T extends Record<string, any> = Record<string, any>> {

private getParams(type: string | RegExp): string[] {
const predicate =
type instanceof RegExp
typeof type !== 'string'
? (t: Token) => type.test(t.type)
: (t: Token) => t.type === type

Expand Down
2 changes: 1 addition & 1 deletion src/tokeniser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const tokenise = (str: string, tokens: Token[] = []): Token[] => {
match: match[0],
val: match.slice(1, 2),
otherVal: match.slice(2),
regex: rule.regex instanceof Function ? rule.regex(match) : rule.regex
regex: typeof rule.regex === 'function' ? rule.regex(match) : rule.regex
})

if (match[0].length < str.length) {
Expand Down