Skip to content

Conversation

@rdzidziguri
Copy link

No description provided.

@troch
Copy link
Owner

troch commented Jun 22, 2016

Thanks for your contribution. This seems perfectly reasonable to add this feature and I'll merge it and release it as soon as I'm finished with what I'm doing (working on another new feature and updating dependencies + build). Should be done by the end of the week.

@rdzidziguri
Copy link
Author

The only question i have regarding this is will step include index or current page? the problem i cam up with this solution was to know which is active step in callback method.

U are welcome i am always glad to contribute to the good OpenSource projects like this.

@rdzidziguri
Copy link
Author

Do we have any update on this?

@rdzidziguri
Copy link
Author

Do we have any status update on this or when we are going to receive new release?

@troch
Copy link
Owner

troch commented Jul 20, 2016

I'm hoping to have an update soon, I've been unable to free some time due to work and family commitments.

@troch
Copy link
Owner

troch commented Jul 24, 2016

The method will pass the active step index, is that fine? Or would prefer it to pass the step object instead?

@rdzidziguri
Copy link
Author

does step include index as its own property? if yest we could pass that object otherwise i do not see reason for this so index would be fine, but again if step instance will include index itself this is best i think/

@troch
Copy link
Owner

troch commented Aug 10, 2016

Nope steps don't include an index as its own property. I think I need to first change how indexing works (they are not zero based, that was a stupid decision) before exposing indexes.

@rdzidziguri
Copy link
Author

Actually after adding controller for step container i thin it is extra to re implement indexing anyone could easily get active step index and using base methods get step info.

@troch
Copy link
Owner

troch commented Aug 11, 2016

OK. I might merge it at some point. I'll rework indexing to be zero based in a near future (breaking change, will bump version to 2.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants