-
Notifications
You must be signed in to change notification settings - Fork 42
step is passed to the onStepChange method as an argument #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution. This seems perfectly reasonable to add this feature and I'll merge it and release it as soon as I'm finished with what I'm doing (working on another new feature and updating dependencies + build). Should be done by the end of the week. |
|
The only question i have regarding this is will step include index or current page? the problem i cam up with this solution was to know which is active step in callback method. U are welcome i am always glad to contribute to the good OpenSource projects like this. |
|
Do we have any update on this? |
|
Do we have any status update on this or when we are going to receive new release? |
|
I'm hoping to have an update soon, I've been unable to free some time due to work and family commitments. |
|
The method will pass the active step index, is that fine? Or would prefer it to pass the step object instead? |
|
does step include index as its own property? if yest we could pass that object otherwise i do not see reason for this so index would be fine, but again if step instance will include index itself this is best i think/ |
|
Nope steps don't include an index as its own property. I think I need to first change how indexing works (they are not zero based, that was a stupid decision) before exposing indexes. |
|
Actually after adding controller for step container i thin it is extra to re implement indexing anyone could easily get active step index and using base methods get step info. |
|
OK. I might merge it at some point. I'll rework indexing to be zero based in a near future (breaking change, will bump version to 2.0.0). |
No description provided.