Restart from VTU#1037
Open
LasNikas wants to merge 117 commits intotrixi-framework:mainfrom
Open
Conversation
…ties and update tests
…celschurer/TrixiParticles.jl into vtk2trixi-return-named-tuple
added 5 commits
January 19, 2026 07:14
LasNikas
commented
Jan 21, 2026
added 8 commits
January 22, 2026 08:51
Member
|
Happy to see that restarting is receiving some TLC |
svchb
requested changes
Apr 29, 2026
Collaborator
svchb
left a comment
svchb
left a comment
There was a problem hiding this comment.
- Add also an example in which you restart TLSPH
- All systems should be covered by tests
svchb
requested changes
Apr 29, 2026
Collaborator
svchb
left a comment
svchb
left a comment
There was a problem hiding this comment.
why don't you read in the index for the buffered particles by modifying vtk2trixi?
As far as I understand it the particles in the buffer don't have to be continuous?
Comment on lines
+197
to
+198
| This has to be a tuple of filenames, one for each system in the [`Semidiscretization`](@ref). | ||
| The order of the filenames has to match the order of the systems in the [`Semidiscretization`](@ref). |
Collaborator
There was a problem hiding this comment.
Unclear meaning of this sentences.
Comment on lines
+36
to
+45
| function time_span(tspan, restart_with::Tuple{Vararg{String}}) | ||
| restart_data = vtk2trixi(first(restart_with)) | ||
| t_restart = convert(eltype(tspan), restart_data.time) | ||
|
|
||
| if !isapprox(tspan[1], t_restart) | ||
| @info "Adjusting initial time from $(tspan[1]) to restart time $t_restart" | ||
| end | ||
|
|
||
| return (t_restart, tspan[2]) | ||
| end |
Collaborator
There was a problem hiding this comment.
This should check if all the files start from the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on
vtk2trixiso that it returns aNamedTupleinstead of anInitialCondition#959