fix(webapp): sanitize streamed agent URLs before rendering in the agent view#3882
Conversation
…nt view URLs in source-url and file message parts come from streamed agent/tool data, so an unsafe scheme like javascript: rendered straight into an href/src was a clickable XSS payload. Allow only http(s)/blob (and data:image for inline images); unsafe values render as plain text instead of a link or image.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
WalkthroughThis PR adds a toSafeUrl helper that validates URL schemes (allowing http:, https:, blob:, and optionally data:image/*), applies it to AgentMessageView rendering for source-url and file parts so unsafe URLs are not used as href/src, adds tests covering allowed/blocked schemes and malformed inputs, and adds a changelog entry documenting the fix. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
3 participants
Summary
The dashboard's Agent view rendered
source-urlandfilemessage parts by putting theirurlstraight into anhref/src. Those URLs come from streamed agent and tool data, so a tool that emitted something likejavascript:alert(1)produced a clickable XSS payload in the dashboard.Fix
A
toSafeUrlhelper now gates every URL before it reaches anhref/src: it allows onlyhttp:/https:/blob:(anddata:image/...for inline images) and returnsnullfor anything else. Unsafe values render as plain text instead of a link or image, so a hostile or malformed URL degrades gracefully rather than becoming clickable. Safe URLs render exactly as before. Covered by a unit test over the allow/deny list.