Skip to content

fix(webapp): scope team-member removal to the caller's org #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lissy93 wants to merge 1 commit into from
+7 −0
Closed

fix(webapp): scope team-member removal to the caller's org #3842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/remove-team-member-org-scope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: fix
---

Scope the `removeTeamMember` delete to the resolved organization so a member can only be deleted from the org they belong to. Previously the delete was keyed by `OrgMember.id` alone, letting a privileged caller in one org delete members of an unrelated org by id (cross-org IDOR).
1 change: 1 addition & 0 deletions apps/webapp/app/models/member.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export async function removeTeamMember({
return prisma.orgMember.delete({
where: {
id: memberId,
organizationId: org.id,
},
include: {
organization: true,
Expand Down