Skip to content

Docs: Document podCleaner.ts #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akamabu wants to merge 1 commit into from
+1 −0
Closed

Docs: Document podCleaner.ts #3597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/supervisor/src/services/podCleaner.ts
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing high-cardinality metric label: batch_size

The batch_size label used at lines 90 and 102 is an unbounded integer, which violates the repository's .cursor/rules/otel-metrics.mdc rule that explicitly lists batchSize under "DO NOT use high-cardinality attributes: Unbounded integers". While batchSize defaults to 500 and is set once in the constructor, it is still technically unbounded (configurable via PodCleanerOptions). This is pre-existing and untouched by this PR, but worth noting for a future cleanup pass since it creates a new time series for every distinct batch size value.

(Refers to line 90)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/** Documents apps/supervisor/src/services/podCleaner.ts module purpose and public usage context */
import { SimpleStructuredLogger } from "@trigger.dev/core/v3/utils/structuredLogger";
import { K8sApi } from "../clients/kubernetes.js";
import { createK8sApi } from "../clients/kubernetes.js";
Expand Down