-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(core): use Promise.allSettled in TracingSDK flush/shutdown #3562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+31
−2
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
c5b5fde
fix(core): use Promise.allSettled in TracingSDK flush/shutdown
github-actions[bot] 1e29a72
fix(core): throw AggregateError after Promise.allSettled to preserve …
github-actions[bot] d7eae64
fix(core): remove duplicate error logging and improve AggregateError …
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/core": patch | ||
| --- | ||
|
|
||
| Fixed TracingSDK.flush() and shutdown() to use Promise.allSettled instead of Promise.all, preventing one provider's rejection from abandoning the other providers' in-flight exports. This fixes an issue where user-emitted trace data (logger.info calls, child spans) could be silently dropped on shutdown when any provider fails to flush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 flush()/shutdown() no longer propagate errors to callers
With
Promise.allSettled,flush()andshutdown()now always resolve (never reject), even when individual providers fail. This changes the public API contract. The callers inmanaged-run-worker.ts:725-738anddev-run-worker.ts:724-737(flushTracingSDK) wrap_tracingSDK?.flush()inPromise.raceinside an outerPromise.allSettled(managed-run-worker.ts:673,dev-run-worker.ts:687), which tracks success/failure viasuccessfulFlushes/failedFlushes. After this PR,flushTracingSDKwill always resolve successfully, so"tracingSDK"will always appear insuccessfulFlusheseven if underlying providers failed. The failure tracking at theflushAlllevel becomes less precise for tracing SDK failures specifically — though the individual provider errors are still logged to console by the new code. This is arguably the right tradeoff (partial success is better than total failure), but reviewers should be aware the caller-level failure detection for tracing is now effectively bypassed.Was this helpful? React with 👍 or 👎 to provide feedback.