fix: prevent IEEE 754 precision loss in BigInt nanosecond conversions#3555
fix: prevent IEEE 754 precision loss in BigInt nanosecond conversions#3555brone1323 wants to merge 1 commit into
Conversation
Multiplying epoch milliseconds by 1_000_000 before converting to BigInt causes IEEE 754 float precision loss (~256ns errors) because the result (~1.7e18) exceeds Number.MAX_SAFE_INTEGER (~9e15). Fix all four affected sites to convert to BigInt first, then multiply: BigInt(ms) * BigInt(1_000_000) This matches the existing correct pattern in convertDateToNanoseconds(). Fixes triggerdotdev#3292
|
|
Hi @brone1323, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis change updates millisecond-to-nanosecond timestamp conversions across the event repository and run engine to use safer BigInt arithmetic. Instead of multiplying a JS number by 1,000,000 and then converting to BigInt, the code now converts to BigInt first and then multiplies. This pattern is applied to utility functions ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
Problem
Several places multiply epoch milliseconds by
1_000_000before converting toBigInt, causing IEEE 754 float precision loss (~±256 ns errors):The product (~1.7×10¹⁸) exceeds
Number.MAX_SAFE_INTEGER(~9×10¹⁵), so the float loses the last few bits before BigInt sees it.Fix
Convert to
BigIntfirst, then multiply — matching the already-correct pattern inconvertDateToNanoseconds()in the same file:Affected locations (4 sites across 3 files)
apps/webapp/app/v3/eventRepository/common.server.tsgetNowInNanoseconds()apps/webapp/app/v3/eventRepository/common.server.tscalculateDurationFromStart()apps/webapp/app/v3/eventRepository/index.server.tsrecordRunEvent()apps/webapp/app/v3/runEngineHandlers.server.tsFixes #3292