-
-
Notifications
You must be signed in to change notification settings - Fork 979
Fix/replay data integrity 2813 #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/replay data integrity 2813 #2960
Conversation
…onventional location
This fix removes the unintended Zod transformation and JSON enforcement in the ReplayRunData schema. It also refines the UI editability rules to be storage-based (not MIME-based) and adds a 512KB safety threshold for browser performance.
|
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a new trace reconciliation system that aligns UI trace data with PostgreSQL run lifecycle states, addressing eventual consistency between Clickhouse and database. Changes include updated payload edit eligibility logic in the replay dialog based on payload type and size, refactored trace event processing in RunPresenter with per-span duration and error tracking, modified throttle behavior to execute first and last calls within a period, simplified payload validation in the replay schema, and expanded test discovery configuration. A new RunEnvironmentMismatchError class is added, the run data shape now includes createdAt timestamp, and comprehensive tests cover the reconciliation logic across various run states. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes ✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (7)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
Closes #
✅ Checklist
Testing
[Describe the steps you took to test this change]
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
💯