-
-
Notifications
You must be signed in to change notification settings - Fork 975
chore(deps): bump @remix-run/node from 2.1.0 to 2.17.2 #2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
9bc5c0d to
34a982e
Compare
|
Dependabot can't authenticate to a private package registry. Because of this, Dependabot cannot update this pull request. |
3411aac to
8e27bf3
Compare
bdfe6b3 to
e2ef675
Compare
Bumps [@remix-run/node](https://github.com/remix-run/remix/tree/HEAD/packages/remix-node) from 2.1.0 to 2.17.2. - [Release notes](https://github.com/remix-run/remix/releases) - [Commits](https://github.com/remix-run/remix/commits/remix@2.17.2/packages/remix-node) --- updated-dependencies: - dependency-name: "@remix-run/node" dependency-version: 2.17.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
e2ef675 to
562fb3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "@react-types/datepicker": "^3.7.1", | ||
| "@remix-run/express": "2.1.0", | ||
| "@remix-run/node": "2.1.0", | ||
| "@remix-run/node": "2.17.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Remix package version mismatch causes duplicate server-runtime installations
Bumping only @remix-run/node from 2.1.0 to 2.17.2 while keeping all other @remix-run/* packages at 2.1.0 creates a version mismatch that violates Remix's compatibility requirements.
Click to expand
The Problem
@remix-run/node@2.17.2 brings its own @remix-run/server-runtime@2.17.2 as a transitive dependency, while the webapp and other Remix packages depend on @remix-run/server-runtime@2.1.0.
From the lockfile:
'@remix-run/node@2.17.2(typescript@5.5.4)':
dependencies:
'@remix-run/server-runtime': 2.17.2(typescript@5.5.4)
This means both versions are installed:
'@remix-run/server-runtime@2.1.0':
'@remix-run/server-runtime@2.17.2':
Impact
The codebase extensively imports from both @remix-run/node and @remix-run/server-runtime directly. For example:
apps/webapp/app/entry.server.tsx:1imports from@remix-run/node(uses 2.17.2's server-runtime)- Many route files import
json,redirect,LoaderFunctionArgsfrom@remix-run/server-runtimedirectly (uses 2.1.0) @remix-run/express@2.1.0and@remix-run/react@2.1.0use 2.1.0's server-runtime
This version mismatch could cause:
- Type incompatibilities between Response/Request objects
- Behavioral differences in utility functions like
json()orredirect() - Session handling inconsistencies
Recommendation
All @remix-run/* packages should be updated together to 2.17.2 to maintain compatibility.
Recommendation: Update all @remix-run/* packages to 2.17.2 together: @remix-run/express, @remix-run/react, @remix-run/serve, @remix-run/server-runtime, @remix-run/dev, @remix-run/eslint-config, and @remix-run/testing should all be bumped to maintain version consistency.
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps @remix-run/node from 2.1.0 to 2.17.2.
Release notes
Sourced from
@remix-run/node's releases.Commits
3920349Version 2.17.264d88deValidate session id in file session storage (#10806)91ef6feVersion 2.17.13000859chore: Update version for release (#10698)3004a98chore: Update version for release (pre) (#10692)fc5cb1fchore: Update version for release (pre) (#10691)3869e0echore: Update version for release (#10643)00107c5chore: Update version for release (pre) (#10642)45df312chore: Update version for release (#10628)f90aa1fchore: Update version for release (pre) (#10627)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.