fix: upgrade to prisma 5.9.1, feathers 4.5.17#3
Open
robblovell wants to merge 1 commit intotriggercode:mainfrom
Open
fix: upgrade to prisma 5.9.1, feathers 4.5.17#3robblovell wants to merge 1 commit intotriggercode:mainfrom
robblovell wants to merge 1 commit intotriggercode:mainfrom
Conversation
Author
|
Has an effort been made to merge this fork into ps73's repo? |
robblovell
commented
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I saw this fork of feathers-prisma that had upgraded to prisma 5. I intend to use this fork and thought it would be good to upgrade to prisma 5.9.1 and feathers 4.5.17 and to contribute some unit tests.
In the original repo: ps73#16
No
Other Information
Adding unit tests for error-handler.ts uncovered what I think is a bug where it has this code:
clearly not ever satisfied. I have updated this to: