add a test file for a directory with a name not ending with a / character#28
Merged
folkertdev merged 1 commit intomainfrom Apr 7, 2026
Merged
add a test file for a directory with a name not ending with a / character#28folkertdev merged 1 commit intomainfrom
folkertdev merged 1 commit intomainfrom
Conversation
folkertdev
force-pushed
the
directory_name_no_slash
branch
from
5684cbd to
e7f77d9
Compare
folkertdev
force-pushed
the
directory_name_no_slash
branch
from
e7f77d9 to
6c0ac96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zip implementations differ when it comes to directory names. Most insist that a directory name ends with a / although the ZIP specification isn't clear about this. There are files in the wild where the directory name does not end with a / and the ZIP implementations will unpack an empty file instead, because they don't look at file attributes to see if a file is a directory or not.
A good implementation should look at the file attributes (file size, directory attribute) and just create a directory. At minimum a linter should report that there is something funky going on.