Add support for remote sudoers#1539
Merged
bjorn3 merged 4 commits intotrifectatechfoundation:mainfrom Apr 15, 2026
Merged
Conversation
689d896 to
0642cce
Compare
bjorn3
requested changes
Apr 7, 2026
Contributor
Author
|
I just updated the documentation with the |
bjorn3
reviewed
Apr 15, 2026
Collaborator
bjorn3
left a comment
There was a problem hiding this comment.
Looks pretty good. Just a couple of small nits.
The directive @socket was previously introduced. This commit adds the logics behind it to read the sudoers rules from that socket.
bjorn3
approved these changes
Apr 15, 2026
Collaborator
|
Thanks for implementing this! |
Member
|
🙏 Thanks everybody for the great and patient collaboration. |
Contributor
Author
|
Thanks for the guidance and patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #1421.
I include four commits in the PR:
@socketdirective (done by @squell)@socket.Some interesting points.
Limiting the "include" level
I replaced the old
safety_countparameter (au8counter limiting the number of included files) by theIncludeStateenum that includes this counter when inclusions are allowed, but also allows to forbid them. This was needed to prevent new inclusions from a socket even if the limit was not reached.Test
I created an e2e test because I needed to create a socket on the filesystem. Otherwise I would have created a unit test.
Protocol
As we discussed some time ago, to make things simpler, the rules must be provided as text through the socket.
Use of AI
The use of AI was limited to:
All the code was produced by me.