Support more than two digits of each unit#210
Open
sampsyo wants to merge 2 commits intotreyhunner:mainfrom
Open
Support more than two digits of each unit#210sampsyo wants to merge 2 commits intotreyhunner:mainfrom
sampsyo wants to merge 2 commits intotreyhunner:mainfrom
Conversation
Now it's possible to do `countdown 100m` or `countdown 120s`.
Owner
|
Nice! My primary use for this is while teaching as well. I'm glad you found it useful @sampsyo. Thanks for the pull request. The only thing I think it would be nice to have is a test or two for more than 2 digits.
To run the tests you can Besides that, this looks great. Thanks! |
Contributor
Author
|
Good call! I've added a couple of tests along those lines. |
treyhunner
added a commit
that referenced
this pull request
Nov 8, 2025
Includes changes from #210 for the newly refactored code Co-authored-by: Adrian Sampson <adrian@radbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thanks for this very useful timer!
I've been using this to display the time remaining in exams for my class this semester. It worked great for both of the preliminary exams because the duration was 50 minutes. But the final exam, which is happening now, is 150 minutes—and it looks like the regexes for parsing durations only allow up to 2 digits (and no hours). So here's a small change that allows both seconds and minutes to be one or more digits. For this exam, for example, I can now do
countdown 150m.Let me know if there's anything else that would be useful in this PR!