Feature: use Path for better cross platform support#3
Open
khawkins98 wants to merge 2 commits intotrendyminds:masterfrom
Open
Feature: use Path for better cross platform support#3khawkins98 wants to merge 2 commits intotrendyminds:masterfrom
khawkins98 wants to merge 2 commits intotrendyminds:masterfrom
Conversation
This stops errors on Windows like:
```
PS C:\...\Documents\GitHub\visual-differ> node index.js
Generating images from your URLs...
■■■■■■■■■■■■■■■■■■■■ ■ 50% | ETA: 15s | 1/2
Diffing images and creating report...
■ 0% | ETA: 0s | 0/1node:fs:599
handleErrorFromBinding(ctx);
^
Error: ENOENT: no such file or directory, open 'screenshots/2022_12_28__11-54-53/1/a.png'
at Object.openSync (node:fs:599:3)
at Object.readFileSync (node:fs:467:35)
at C:\Users\...\Documents\GitHub\visual-differ\index.js:97:10 {
errno: -4058,
syscall: 'open',
code: 'ENOENT',
path: 'screenshots/2022_12_28__11-54-53/1/a.png'
}
Node.js v18.4.0
```
Puppeteer was about a year out of date, nice to test on a more recent version of chromium.
Author
|
I've also tossed in a package.json dependency update. Meant to do that as a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops errors on Windows like: