ci: ensure portable jextract code, to match deploy release build#173
Open
Marcono1234 wants to merge 2 commits intotree-sitter:masterfrom
Open
ci: ensure portable jextract code, to match deploy release build#173Marcono1234 wants to merge 2 commits intotree-sitter:masterfrom
Marcono1234 wants to merge 2 commits intotree-sitter:masterfrom
Conversation
Marcono1234
commented
Jan 2, 2026
| java-version: [23, 24, 25] | ||
| # To match the release build workflow, use the jextract generated code for Linux and | ||
| # verify that it is portable | ||
| use-jextract-linux-code: [true] |
Contributor
Author
There was a problem hiding this comment.
Side note: GitHub currently implicitly includes the matrix arguments in the job name, e.g. "Test package (windows-latest, 25, true)". Is that ok or would you prefer if name was more descriptive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #171 and #172
Changes the
ci.ymlworkflow so that it is more similar to thedeploy.ymlworkflow, by running jextract on Linux and then using that code on the other platforms (Windows and macOS).The changes have this effect:
(to match what
deploy.ymlis doing; this also surfaces the failures of Version 0.26.0 does not work on Windows due to incompatible jextract code #171)(this is mainly to ensure that local builds on these platforms work, in case users build the project themselves instead of using the release versions)
What do you think?