fix: Retry POST against 502, 503 and 504 responses#134
Open
kar0t wants to merge 2 commits intotreasure-data:masterfrom
Open
fix: Retry POST against 502, 503 and 504 responses#134kar0t wants to merge 2 commits intotreasure-data:masterfrom
kar0t wants to merge 2 commits intotreasure-data:masterfrom
Conversation
7e6ea27 to
67484cc
Compare
67484cc to
a2dc9e5
Compare
exoego
reviewed
Dec 12, 2024
exoego
reviewed
Dec 12, 2024
Contributor
exoego
left a comment
There was a problem hiding this comment.
Please add test.
trino-client-ruby/spec/statement_client_spec.rb
Lines 592 to 632 in 55c3bdc
Contributor
Author
|
I am writing a test for the modified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Retry POST against 50X responses.
Here's what I'd like to see reviewed
faraday_get_with_retryas much as possible.Overview
According to the trino client protocol, it should also retry for POST.
Checklist