activity string is at MotionActivityEvent.type#1335
Open
chrisdrackett wants to merge 1 commit intotransistorsoft:masterfrom
Open
activity string is at MotionActivityEvent.type#1335chrisdrackett wants to merge 1 commit intotransistorsoft:masterfrom
MotionActivityEvent.type#1335chrisdrackett wants to merge 1 commit intotransistorsoft:masterfrom
Conversation
mreda7
approved these changes
Sep 22, 2021
|
Why not set the actual types instead of string? I raised my own PR that changes both erros: |
Contributor
|
any update here? |
|
There hasn't been any movement on this since August last year so I took the liberty of creating a new PR that resolves the union type comment. Please see #1624. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.