Draft
Conversation
Member
|
@marcorieser if this is ready, can you get the tests passing? |
Author
|
@edalzell yes, sorry |
Member
|
@marcorieser can you please describe the issue this fixes and add a test? |
Author
|
@edalzell, this issue happened only when, e.g., you fetched the calendar for March, which has an event in a different timezone and would start already in February UTC. Then it gets appended to the end of the list of days instead of the start (February should come before March). But (if I understood correctly), this shouldn't happen in the v6 compatible version because of your fix. Additionally, the tests are broken on the v5 branch. Let's see if we need that PR at all in the end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.