Add default CURLOPT_TIMEOUT parameter.#91
Open
ericnorris wants to merge 1 commit intotpyo:masterfrom
ericnorris:master
Open
Add default CURLOPT_TIMEOUT parameter.#91ericnorris wants to merge 1 commit intotpyo:masterfrom ericnorris:master
ericnorris wants to merge 1 commit intotpyo:masterfrom
ericnorris:master
Conversation
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without having CURLOPT_TIMEOUT set, any application using this library can build up a large number of open connections if S3 starts having issues.
It seems reasonable to have a default parameter that you can optionally override in order to prevent this situation from happening.