-
-
Notifications
You must be signed in to change notification settings - Fork 9
Fix histogram bin midpoints + other doc improvements #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ruff-py310 #364 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 18 18
Lines 657 657
Branches 85 85
============================================
Hits 657 657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Owner
Author
|
@codex review |
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Signed-off-by: Tomas Pereira de Vasconcelos <tomasvasconcelos1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the codebase, focusing on documentation clarity, developer experience, and a minor bug fix in histogram binning. The most significant changes include updating the basic examples throughout the documentation, improving how Plotly.js is loaded for the docs (with a CDN fallback), fixing histogram bin center calculation, and cleaning up test and manifest files. Additionally, developer tooling is enhanced with a Cursor worktree config.
Documentation and Example Updates:
Updated all basic examples in the documentation and code to use new sample generation logic and consistent parameters for clarity and reproducibility (
README.md,docs/index.md,docs/getting_started/getting_started.md,cicd_utils/ridgeplot_examples/_basic.py,cicd_utils/ridgeplot_examples/_basic_hist.py,src/ridgeplot/__init__.py) [1] [2] [3] [4] [5] [6].Improved documentation build process to bundle a local copy of
plotly.min.jsas a fallback if the CDN is unavailable, and updated the Sphinx template to load Plotly dynamically (docs/_templates/base.html,docs/Makefile,Makefile,docs/conf.py,MANIFEST.in) [1] [2] [3] [4] [5].Bug Fixes:
bin_trace_samplesto use actual bin centers instead of edges, ensuring correct histogram rendering (src/ridgeplot/_hist.py).Developer Experience and CI/CD:
.cursor/worktrees.jsonconfig to support Cursor worktrees for improved developer workflow.MANIFEST.in).docs/reference/changelog.md).Code Quality and Maintenance:
cicd_utils/ridgeplot_examples/_base.py) [1] [2] [3]..jpgto.jpegfor consistency (docs/getting_started/getting_started.md,MANIFEST.in) [1] [2].