Skip to content

Conversation

@tpvasconcelos
Copy link
Owner

@tpvasconcelos tpvasconcelos commented Nov 30, 2024

Description

Implement histogram binning and trace_type="bar"

Related issues

closes #194

PR check list

  • Read the contributing guidelines.
    • You don't have to read the whole thing, but it's a good idea to skim it. And definitely take a look at it if you're experiencing any issues getting your local environment up and running.
  • Provided the relevant details in the PR's description.
  • Referenced relevant issues in the PR's description.
  • Added tests for all my changes.
    • The CI will fail unless 100% of all new code is covered by the tests.
  • Updated the docs for relevant changes.
    • New modules (or renamed ones) are included in docs/api/internal/.
    • New public functions/classes/variables are documented in docs/api/index.rst.
    • Added the appropriate versionadded, versionchanged, or deprecated directives to docstrings.
      • The version should be the next release version, which you can infer by bumping the minor version in MAJOR.MINOR.PATCH (e.g., if the current version is 0.2.3, the next release will be 0.3.0).
  • Changes are documented in docs/reference/changelog.md.
    • Please try to follow the conventions laid out in the file. In doubt, just ask!
  • Consider granting push permissions to your PR's branch, so maintainers can help you out if needed.
  • The CI check are all passing, or I'm working on fixing them!
  • I have reviewed my own code! 🤠

📚 Documentation preview 📚: https://ridgeplot--287.org.readthedocs.build/en/287/

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9be16d1) to head (3e46c04).
Report is 108 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #287   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        18    +5     
  Lines          549       645   +96     
  Branches        73        81    +8     
=========================================
+ Hits           549       645   +96     
Flag Coverage Δ
combined-src 99.37% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpvasconcelos tpvasconcelos marked this pull request as ready for review December 5, 2024 00:08
Copy link
Owner Author

@tpvasconcelos tpvasconcelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review these changes 👇

@tpvasconcelos tpvasconcelos merged commit 1691dd5 into main Dec 5, 2024
15 of 16 checks passed
@tpvasconcelos tpvasconcelos deleted the 194-histograms branch December 5, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ridge histograms

2 participants