feat: (wip) try to add pattern prop support#13
Open
dradetsky wants to merge 1 commit intotouchifyapp:masterfrom
Open
feat: (wip) try to add pattern prop support#13dradetsky wants to merge 1 commit intotouchifyapp:masterfrom
dradetsky wants to merge 1 commit intotouchifyapp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This isn't really ready. It's untested, I haven't even built the repo successfully with this change, etc (hence issue #12). But I figured I might as well push this up, since I can always throw it away, and also the maintainers can look at it and say
A: This is completely the wrong way to implement this, and here's why; or
B: This is maybe something we want, here's some help on how you can build/test the change so it's less work for us to accept the PR; or
C: This is maybe something we want, so we'll just steal the ideas from it & add them.