Skip to content

feat: add back as_query method to AwaitableQuery#2194

Open
seladb wants to merge 2 commits into
tortoise:developfrom
seladb:add-back-as-query
Open

feat: add back as_query method to AwaitableQuery#2194
seladb wants to merge 2 commits into
tortoise:developfrom
seladb:add-back-as-query

Conversation

@seladb
Copy link
Copy Markdown
Contributor

@seladb seladb commented May 15, 2026

Description

Addresses #2056: bring back AwaitableQuery.as_query().

Motivation and Context

As described in #2056 there are cases where users have complex queries and need access to the internal pypika layer. The as_query() method used to exist but was removed in #1777. I don't see a reason why not to add it back.

How Has This Been Tested?

Yes, tests added int this PR.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing seladb:add-back-as-query (cb0d601) with develop (c0de49f)

Open in CodSpeed

@seladb seladb changed the title Add back as_query method to AwaitableQuery feat: add back as_query method to AwaitableQuery May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant