Introduce SqlDefault for using expression as db_default#2106
Merged
Conversation
Pull Request Test Coverage Report for Build 21944692887Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2104
Introduce SqlDefault to pass expressions as db default
Change schema generator behaviour to match migrations (no default in db on
defaultinField)AI Summary:
This pull request introduces support for raw SQL default expressions in database schemas via new
SqlDefaultandNowexpressions, and clarifies the distinction between Python-only defaults and database-level defaults. It also updates documentation and tests to reflect these changes, and adjusts schema generation so that Python-only defaults (such asdefault=...,auto_now, andauto_now_add) do not emitDEFAULTclauses in generated schemas.New features and API additions:
SqlDefaultandNowexpressions for use with thedb_defaultparameter, allowing raw SQL expressions (e.g.,CURRENT_TIMESTAMP) as database defaults.Now()is a shorthand forSqlDefault("CURRENT_TIMESTAMP"). [1] [2] [3] [4] [5] [6]Behavior changes and schema generation:
Field(default=...),auto_now, andauto_now_addno longer emit aDEFAULTclause ingenerate_schemas(). Onlydb_defaultis used for database-level defaults, aligning schema generation with migration behavior. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Documentation improvements:
db_default,SqlDefault, andNow. [1] [2] [3]Testing:
SqlDefaultandNow, including construction, equality, hashing, schema generation, migration rendering, and serialization.Examples and migrations:
SqlDefaultandNowin real project scenarios. [1] [2] [3]