PM-3357 - make sure to filter out profileCompleteness categories #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const [count, incompleteEntries] = useMemo(() => { | ||
| const fields = Object.entries(completeness.entries) | ||
| .filter(([, value]) => !value) | ||
| .filter(([, value]) => value === false || value === null || value === undefined) |
There was a problem hiding this comment.
[💡 maintainability]
The filter condition value === false || value === null || value === undefined is technically correct, but consider using value == null to check for both null and undefined in a more concise way. This can improve readability and maintainability.
| @@ -1,3 +1,4 @@ | |||
| import { omit } from 'lodash' | |||
There was a problem hiding this comment.
[performance]
Consider using a more specific import from lodash, such as import omit from 'lodash/omit', to potentially reduce bundle size if tree-shaking is not fully effective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-3357
What's in this PR?