Skip to content

fix(PM-2540): removed isAIReviewer from challenge schema#20

Closed
hentrymartin wants to merge 1 commit intodevelopfrom
pm-2540_cleanup
Closed

fix(PM-2540): removed isAIReviewer from challenge schema#20
hentrymartin wants to merge 1 commit intodevelopfrom
pm-2540_cleanup

Conversation

@hentrymartin
Copy link
Copy Markdown

What's in this PR?

  • We have removed isAIReviewer column from DefaultChallengeReviewer table in challenge schema.
  • This PR is to remove it here and update scorecardId as nullable

trackId String
// Reviewer configuration (mirrors ChallengeReviewer)
scorecardId String
scorecardId String?
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Changing scorecardId from String to String? makes it nullable. Ensure that the application logic correctly handles cases where scorecardId is null, as this could lead to unexpected behavior if not properly managed.

incrementalCoefficient Float?
opportunityType ReviewOpportunityTypeEnum?
isAIReviewer Boolean
aiWorkflowId String?
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The addition of aiWorkflowId as String? introduces a nullable field. Verify that any logic dependent on aiWorkflowId being non-null is updated to handle null values appropriately to avoid potential null reference errors.

@kkartunov kkartunov closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants