fix(PM-2540): removed isAIReviewer from challenge schema#20
Closed
hentrymartin wants to merge 1 commit intodevelopfrom
Closed
fix(PM-2540): removed isAIReviewer from challenge schema#20hentrymartin wants to merge 1 commit intodevelopfrom
hentrymartin wants to merge 1 commit intodevelopfrom
Conversation
| trackId String | ||
| // Reviewer configuration (mirrors ChallengeReviewer) | ||
| scorecardId String | ||
| scorecardId String? |
There was a problem hiding this comment.
[❗❗ correctness]
Changing scorecardId from String to String? makes it nullable. Ensure that the application logic correctly handles cases where scorecardId is null, as this could lead to unexpected behavior if not properly managed.
| incrementalCoefficient Float? | ||
| opportunityType ReviewOpportunityTypeEnum? | ||
| isAIReviewer Boolean | ||
| aiWorkflowId String? |
There was a problem hiding this comment.
[❗❗ correctness]
The addition of aiWorkflowId as String? introduces a nullable field. Verify that any logic dependent on aiWorkflowId being non-null is updated to handle null values appropriately to avoid potential null reference errors.
kkartunov
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?