Remove Author.email field and merge authors by name#10
Open
filodej wants to merge 8 commits intotomgi:masterfrom
Open
Remove Author.email field and merge authors by name#10filodej wants to merge 8 commits intotomgi:masterfrom
filodej wants to merge 8 commits intotomgi:masterfrom
Conversation
For example "John Smith <john.smith@example.com>" and "John Smith <jsmith@example.com>" are considered as a single author regardless of the different email addresses. This change is just a workaround. But as the URL for author details is constructed from Autor.dirname (as opposed to Author.email - see dc4d2a0) the original version does not work anyway. This seems to me as a suitable quickfix until the whole issue is properly addressed.
|
+1 |
Owner
|
Thanks for pointing the problem with author details URL. I think better solution than removing email field from author would be to:
|
Author
|
Hello Tomasz, |
Closed
|
Ping for this - CLI-wise, I agree that a toggle to allow the operator to turn off the email behavior is a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example
John Smith <john.smith@example.com>andJohn Smith <jsmith@example.com>are considered as a single authorJohn Smithregardless of the different email addresses.As the URL for author details is constructed from
Autor.dirname(as opposed toAuthor.email- see dc4d2a0) the original version does not work properly.This change is just a workaround and is not intended for a direct merge, I created it just to trigger a discussion.
However, for me personally it feels as a suitable quickfix until the whole issue is properly addressed.