Update markerWithlabel to fix onRemoveChild issue.#903
Open
anudeep1426 wants to merge 1 commit intotomchentw:masterfrom
Open
Update markerWithlabel to fix onRemoveChild issue.#903anudeep1426 wants to merge 1 commit intotomchentw:masterfrom
anudeep1426 wants to merge 1 commit intotomchentw:masterfrom
Conversation
Author
|
In previous version 2.0.1 of markerwithlabel, there were no validations added while unmounting the markerwithlabel. after updating with 2.0.2 the issue has been resolved. |
|
@anudeep1426 thank you for the findings. But there's already a PR made against this issue #894 |
Author
|
@sakhisheikh , Yeah i see you also have a pull request for the same issue. okay, then we can close this with reference to that issue. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE CHECK "Allow edits from maintainers"
FOLLOW "Conventional Commits Specification" FOR ALL COMMITS
https://conventionalcommits.org/