feat(snowflake)!: transpilation support current_version#6960
Merged
Conversation
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 4003 total, 4003 passed (pass rate: 100.0%), sqlglot version: sqlglot:RD-1069314-transpile-current_version: 4003 total, 4003 passed (pass rate: 100.0%), sqlglot version: Difference: No change |
geooo109
reviewed
Feb 5, 2026
Collaborator
There was a problem hiding this comment.
Let's also include tests.
Moreover, why we have introduced a new token ?
We want to cover the transpilation from Snowflake -> Duckdb.
In snowflake:
ast = parse_one("SELECT CURRENT_VERSION()", dialect="snowflake")
ast:
Select(
expressions=[
CurrentVersion()])
So, we only need to apply the rename in the duckdb generator. (as you have already added)
Let's also add the parsing of the version in duckdb, and test the roundtrip.
georgesittas
reviewed
Feb 5, 2026
cc699a7 to
f695512
Compare
Collaborator
|
I will merge and take it to the finish line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transpilation support for current_version()