Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18144a4048
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| (ert-deftest ai-code-test-menu-ai-cli-session-includes-select-terminal-entry () | ||
| "Test that the AI CLI session menu exposes terminal backend selection." | ||
| (let ((suffix (transient-get-suffix 'ai-code--menu-ai-cli-session "T"))) |
There was a problem hiding this comment.
Use the actual menu key when asserting suffix lookup
The new transient entry is bound to key "l" in ai-code--menu-ai-cli-session (ai-code.el), but this test looks up key "T"; as a result transient-get-suffix returns nil and the test fails even when the feature works. This breaks the test suite for this commit and prevents the assertion from validating the newly added menu binding.
Useful? React with 👍 / 👎.
Provide a menu item to select across vterm / eat / ghostel